Fix: Apply Unique LogRequestResponse Options for Multiple HttpClients #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lients additionally switch to keyed transient handler when .net8
|
hello @aburgel @alirezavafi @Azaferany |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the problem where custom RequestLoggingOptions applied via HttpClientBuilderExtensions.LogRequestResponse are not uniquely respected for multiple HttpClients in an ASP.NET Core app running on .NET 6. My changes ensure that each HttpClient correctly applies its configured logging options.
Additionally I added an additional service to the sample project to demonstrate the support for independent options.
Related Issue:
Fixes #6